juniper icon indicating copy to clipboard operation
juniper copied to clipboard

Strange formatting when using "as_schema_language"

Open mrtnzlml opened this issue 3 years ago • 2 comments

Hello! I noticed the following strange formatting (pay attention to the unitAmountCurrency field how it sits behind the comment):

input ProductPriceInput {
  """
    The unit amount in centavo to be charged, represented as a whole integer.
    Centavo equals ¹⁄₁₀₀ of the basic monetary unit.
  """ unitAmount: Int!
  "Three-letter [ISO currency code](https://www.iso.org/iso-4217-currency-codes.html)." unitAmountCurrency: SupportedCurrency!
}

See: https://github.com/adeira/universe/blob/d1e60f44855dd5221c86c818188ba31163ec2342/src/ya-comiste-meta/schema.graphql#L100-L106

There is a similar output object where this is not happening:

type ProductPrice {
  """
    The unit amount in centavo to be charged, represented as a whole integer.
    Centavo equals ¹⁄₁₀₀ of the basic monetary unit.
  """
  unitAmount: Int!
  "Three-letter [ISO currency code](https://www.iso.org/iso-4217-currency-codes.html)."
  unitAmountCurrency: SupportedCurrency!
}

See: https://github.com/adeira/universe/blob/d1e60f44855dd5221c86c818188ba31163ec2342/src/ya-comiste-meta/schema.graphql#L157-L165

The input is defined here: https://github.com/adeira/universe/blob/d1e60f44855dd5221c86c818188ba31163ec2342/src/ya-comiste-rust/server/src/commerce/model/products.rs#L147-L155

Thanks for having a look! 😎

mrtnzlml avatar Feb 15 '21 23:02 mrtnzlml

I just encountered another case where this is happening (enums with Rust doc comments):

enum ProductMultilingualInputVisibility {
  "Visible in backoffice only (accessible to authorized users)." PRIVATE
  "Visible in eshop only (therefore it's public)." ESHOP
  "Visible in POS only (accessible to authorized users)." POS
  "Visible everywhere (in public eshop, POS and of course backoffice)." EVERYWHERE
}

mrtnzlml avatar Feb 16 '21 18:02 mrtnzlml

Interesting. We use https://github.com/graphql-rust/graphql-parser 's AST printing, sounds like a bug there possibly?

LegNeato avatar Feb 26 '21 20:02 LegNeato