juniper icon indicating copy to clipboard operation
juniper copied to clipboard

Leverage Slog And Or Log For Debugging Output

Open TheServerAsterisk opened this issue 8 years ago • 5 comments

There is some debugging information that is getting outputted in the graphql_input_object macro namely on line 70. Either, logging framework like Slog or Log should be used for outputting debugging information or this line and others like it should be removed.

TheServerAsterisk avatar May 17 '17 19:05 TheServerAsterisk

I think that all println! not in tests or the example should be removed - I probably accidentally committed them :)

It might be a good idea to support e.g. Slog in the executor, just so that an application developer can get a useable trace from Juniper if they're trying to debug field execution or something.

mhallin avatar May 17 '17 19:05 mhallin

Not gonna promise anything as I might overload on turkey, but I'll try to get this done on the weekend. @theduke, @mhallin or @LegNeato any strong opinions on what should be logged? I guessing we should use Slog as that looks like to be the de facto for logging.

piperRyan avatar Oct 04 '18 19:10 piperRyan

@piperRyan - did you end up making any progress on this? I was looking for a way to contribute and this seemed like a good path

graysonarts avatar Feb 20 '19 23:02 graysonarts

@RussTheAerialist Unfortunately I have been quite busy, so if you wanted to tackle this one you can go ahead! :)

piperRyan avatar Feb 22 '19 17:02 piperRyan

Continued in #423 .

theduke avatar Aug 30 '19 19:08 theduke