juniper icon indicating copy to clipboard operation
juniper copied to clipboard

Add graphql-ws support in light of subscriptions-transport-ws deprecation

Open bglw opened this issue 4 years ago • 5 comments

This was mentioned in #896 but declined at that point. Since then, however, the winds of change have blown in favor of graphql-ws. The graphql-ws protocol differs from Apollo's original subscriptions-transport-ws protocol, and Apollo are soon to archive their protocol and are now recommending use of graphql-ws.

There is already some friction, as graphql-ws-client (and most ws clients coming out) only support the new protocol, while juniper only supports the old.

bglw avatar Feb 07 '22 10:02 bglw

@bglw thanks. We have plans to support both versions for the next major release.

tyranron avatar Feb 08 '22 10:02 tyranron

@tyranron this feature is landed? :) was thinking that maybe I can be a good mentee? because I would like to have this feature

vincenzopalazzo avatar Jun 30 '22 01:06 vincenzopalazzo

@vincenzopalazzo nope, haven't touched it yet. Would like to see a PR from you, if you're willing to. As for design, I think it should be feature-gated in the existing crate. Thanks.

tyranron avatar Jun 30 '22 15:06 tyranron

lets see if I can put in my todo list :) there is any channel that can make easy the onboarding on the package?

vincenzopalazzo avatar Jun 30 '22 16:06 vincenzopalazzo

@vincenzopalazzo just ask directly in the related PR.

tyranron avatar Jun 30 '22 17:06 tyranron