graphql-ws icon indicating copy to clipboard operation
graphql-ws copied to clipboard

Update to graphene v3 ?

Open ldynia opened this issue 3 years ago • 8 comments

Hi @SmileyChris

I am wondering if you are gonna create a pre-release of the project to support graphene 3, and when would that be ?

Best

ldynia avatar May 10 '21 13:05 ldynia

Would love to have that as well!

f-tepel avatar Jul 06 '21 08:07 f-tepel

@ldynia and @f-tepel -- got any time to help with that? I'd love to get a graphene 3 branch underway.

SmileyChris avatar Jul 06 '21 21:07 SmileyChris

What would have to be done? (I am new to open-source) @SmileyChris

f-tepel avatar Jul 07 '21 06:07 f-tepel

pgzmnk avatar Dec 24 '21 16:12 pgzmnk

Also looking forward how/if it is working with graphene v3

ceelian avatar Jul 24 '22 18:07 ceelian

Hey if anyone is interested, I have a github repo here: https://github.com/jtc3161/graphql-ws-aiohttp that is a fork of https://github.com/dls-controls/graphql-ws-aiohttp, which was written by @callumforrester who posted https://github.com/graphql-python/graphql-ws/issues/90 a while back.

I have:

  • implemented the newer "graphql-transport-ws" protocol ("graphql-ws" was deprecated a while back)
  • production tested against both the python and Typescript graphql-ws client implementations, with android, ios and web clients actively using it.

Some of my thoughts:

  • maybe we should support both graphql-ws and graphql-transport-ws as a way to support older clients, though the Typescript server does not do this, so I didn't either in this repo.
  • This is a downstream fork of graphql-ws-next and not graphql-ws. graphql-ws next is much closer to the typescript reference implementation though so I do not think that is a downside.

Unfortunately I'm neck deep in the project that I built this for, so the repo is not exactly up to the standards of most oss projects, but I could definitely spend some time fleshing this out more if there is any buy in from maintainers.

jtc3161 avatar May 02 '23 13:05 jtc3161

@jtc3161 awesome work! Maybe there's a way to integrate this with graphql-server so we reduce the amount of libraries we need to maintain. /cc @kiendang

Feel free to join our discord server and ping us there!

https://discord.gg/UszdMbZhdc

erikwrede avatar May 02 '23 18:05 erikwrede

There's an implementation for Subscriptions via WebSocket in the v3 branch of graphql-python/graphql-server. I've create graphql-python/graphql-server#112 to track making official support for it. As Erik said if you're interested in GraphQL Subscriptions for Graphene 3 please join the Discord server to discuss.

kiendang avatar May 31 '23 06:05 kiendang