graphql-relay-py icon indicating copy to clipboard operation
graphql-relay-py copied to clipboard

fix: align previous/next page flag with relay standard

Open tcleonard opened this issue 1 year ago • 2 comments

solves issue #12 corresponding MR on the Javascript version: https://github.com/graphql/graphql-relay-js/pull/388

tcleonard avatar Sep 05 '22 20:09 tcleonard

@Cito the goal of this MR is to align the computation of the page info with the relay official spec. Indeed the computation of the "has previous/next page" flags was not matching what is defined in the documentation. I have added unit tests for the missing cases. Since the standard definition can return unexpected result in some cases I left some comment to make that very explicit that it is not a bug.

tcleonard avatar Sep 05 '22 20:09 tcleonard

@tcleonard I want to wait how this is resolved in graphql-relay-js before I port it here.

Cito avatar Sep 12 '22 12:09 Cito