graphql-core-legacy icon indicating copy to clipboard operation
graphql-core-legacy copied to clipboard

Published 20 hours ago • verified publisher icon graphql-python

Implement nullvalue

Open yen223 opened this issue 7 years ago • 11 comments

Resolves #118

yen223 avatar May 11 '17 13:05 yen223

I will happily merge this if we can add more tests like in the ref implementation! https://github.com/graphql/graphql-js/pull/544/files :)

syrusakbary avatar Jun 06 '17 02:06 syrusakbary

@yen223 Do you plan to continu this PR? That's a very useful feature.

waxisien avatar Oct 03 '17 00:10 waxisien

What's the status of this pull request? This would be very helpful for us.

mrshankly avatar Aug 02 '18 11:08 mrshankly

This feature would be very useful. Right now, I have to create another mutation that's used only for setting argument object fields to null.

rok-povsic avatar Sep 11 '18 19:09 rok-povsic

I will happily merge this if we can add more tests like in the ref implementation! https://github.com/graphql/graphql-js/pull/544/files :)

@syrusakbary which, specifically, of the tests there would you like implemented? It seems to me that project has a broader set of tests overall than this one and the tests @yen223 added are consistent with the scope of the existing tests.

altaurog avatar Nov 07 '18 16:11 altaurog

Any update on this? thanks

samlll42-github avatar Nov 15 '18 21:11 samlll42-github

Joining the crowd of onlookers waiting for updates on this PR. Thanks @syrusakbary

ArnaudPel avatar Apr 10 '19 10:04 ArnaudPel

likewise, would very much like this to be possible

kkitay avatar Apr 19 '19 18:04 kkitay

Joining the crowd of onlookers waiting for updates on this PR. Thanks @syrusakbary

hugos94 avatar May 10 '19 13:05 hugos94

~~Joining the crowd of onlookers waiting for updates on this PR. Thanks @syrusakbary~~

Maybe the https://github.com/graphql-python/graphql-core/issues/249 release might resolve this issue, @jkimbo?

brabeji avatar Aug 05 '19 09:08 brabeji

@brabeji yes the graphql-core v3 (#249) will resolve this issue. Graphql-core v3 is going to be graphql-core-next which is a complete rewrite bringing it up to feature parity with graphql.js

jkimbo avatar Aug 18 '19 18:08 jkimbo