graphene icon indicating copy to clipboard operation
graphene copied to clipboard

Update Dataloader docs [Waiting for Graphene v3 to be live]

Open jkimbo opened this issue 4 years ago • 3 comments

Resolves #1189

Also adds a basic to test to make sure that aiodataloader works.

jkimbo avatar Apr 26 '20 12:04 jkimbo

Has everyone lost interest in this project? 8 pending reviewers 7 months after the MR was created.. This isn't confidence inspiring for others who are thinking of contributing :) Is there perhaps conversation about this elsewhere?

skewty avatar Nov 27 '20 02:11 skewty

Has everyone lost interest in this project? 8 pending reviewers 7 months after the MR was created.. This isn't confidence inspiring for others who are thinking of contributing :) Is there perhaps conversation about this elsewhere?

@skewty there are some discussions about contributing on slack https://graphenetools.slack.com/

fabienheureux avatar May 27 '21 07:05 fabienheureux

Why isn't this merged?

The documentation is wrong and if you are using the latest Graphene version the data loaders didn't work.

Do you need any change in the proposed change? I can create a new PR with the changes if needed

nykolaslima avatar Jan 28 '22 23:01 nykolaslima

Codecov Report

Merging #1190 (8e1c3d3) into master (80e3498) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1190   +/-   ##
=======================================
  Coverage   95.59%   95.59%           
=======================================
  Files          49       49           
  Lines        1565     1565           
=======================================
  Hits         1496     1496           
  Misses         69       69           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov-commenter avatar Aug 13 '22 13:08 codecov-commenter