graphene-django icon indicating copy to clipboard operation
graphene-django copied to clipboard

Published 20 hours ago • verified publisher icon graphql-python

Associate GlobalIDFilter with BigAutoField and SmallAutoField

Open iamthad opened this issue 1 year ago • 2 comments

AutoField is set up to use GlobalIDFilter, but BigAutoField and SmallAutoField are not.

This PR adds them to GRAPHENE_FILTER_SET_OVERRIDES, associating them with the filter.

It also removes some conditional logic around SmallAutoField that was introduced in #1212 because SmallAutoField was introduced in Django 3.0 and this project now requires a minimum Django version of 3.2.

iamthad avatar Feb 01 '24 16:02 iamthad

I originally added the BigAutoField support. This was definitely missed so thanks! LGTM

pizzapanther avatar Feb 01 '24 16:02 pizzapanther

I realized today, that in the spirit of https://xkcd.com/1172/, this will be a breaking change for those who were relying on the old behavior. Their APIs will start requiring global IDs on ID filters instead of integers.

How should this be addressed? Maybe a note in the changelog about how to restore the old behavior would be sufficient?

iamthad avatar Feb 02 '24 17:02 iamthad