graphene-django icon indicating copy to clipboard operation
graphene-django copied to clipboard

Move testing endpoint to settings

Open syberen opened this issue 4 years ago • 2 comments

Fix #866

PLEASE NOTE: this will break testing for folks who have not pinned their version number, so maybe best to add to v3. I'm not sure which base branch to use for that, so please advise.

  • Make default testing endpoint consistent with graphql endpoint suggested in the installation documentation (/graphql)
  • Import testing endpoint from settings, provide default
  • Add test
  • Document default testing endpoint, and how to override in settings

syberen avatar Jan 24 '21 07:01 syberen

this will break testing for folks who have not pinned their version number,

I'm not sure this should be a concern of library/tool developers. If a breaking change is documented well enough, it's okay imo. I'll try to review rest of it today.

ulgens avatar Jan 24 '21 08:01 ulgens

@ulgens Would you have time for a review?

syberen avatar May 05 '21 08:05 syberen

Hello @syberen , would you please resolve these conflicts so we can get it ready to be merged?

firaskafri avatar Sep 23 '22 08:09 firaskafri

Hello @syberen , would you please resolve these conflicts so we can get it ready to be merged?

Hi @firaskafri, I see you merged main already, do you still need my assistance? It might take a few days due to my schedule

syberen avatar Sep 24 '22 13:09 syberen

Hello @syberen , would you please resolve these conflicts so we can get it ready to be merged?

Hi @firaskafri, I see you merged main already, do you still need my assistance? It might take a few days due to my schedule

Hello @syberen ! Yes it was a very tine conflict, but now seems that some of the tests are failing due to black formatting, would you please check when you have time?

firaskafri avatar Sep 24 '22 14:09 firaskafri