gql icon indicating copy to clipboard operation
gql copied to clipboard

Update annotation for client.execute_batch, get_execution_result argu…

Open rahul-gj opened this issue 1 year ago • 1 comments

…ment.

client.execute_batch was showing "No overload for provided arguments" in Pylance for vscode. Had to provide argument for get_execution_result to suppress error. Update overloads to have default values to overcome this.

rahul-gj avatar Jun 12 '24 07:06 rahul-gj

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (9052403) to head (e6d5b87). Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #483   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           29        29           
  Lines         2629      2629           
=========================================
  Hits          2629      2629           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jun 12 '24 09:06 codecov[bot]

@rahul-gj Sorry for the delay. I modified the get_execution_result argument typing so that it is identical to the other methods in the file. I believe this could solve your problem.

I don't use vscode or pylance so if you could verify that would be nice.

Thanks for the report!

leszekhanusz avatar Jul 28 '24 15:07 leszekhanusz