gql icon indicating copy to clipboard operation
gql copied to clipboard

Chore update graphql core to 3.3.0 and dropping support for Python 3.6

Open leszekhanusz opened this issue 2 years ago • 2 comments

leszekhanusz avatar Sep 24 '22 22:09 leszekhanusz

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage :thumbsup:

Coverage data is based on head (71c5c1a) compared to base (5e47f5f). Patch has no changes to coverable lines.

:exclamation: Current head 71c5c1a differs from pull request most recent head f8e2a75. Consider uploading reports for the commit f8e2a75 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #363   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           24        24           
  Lines         2215      2215           
=========================================
  Hits          2215      2215           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Sep 24 '22 22:09 codecov[bot]

̶@̶C̶i̶t̶o̶ ̶a̶n̶y̶ ̶i̶d̶e̶a̶ ̶w̶h̶y̶ ̶p̶y̶p̶y̶3̶ ̶c̶a̶n̶n̶o̶t̶ ̶f̶i̶n̶d̶ ̶g̶r̶a̶p̶h̶q̶l̶-̶c̶o̶r̶e̶ ̶v̶e̶r̶s̶i̶o̶n̶ ̶3̶.̶3̶.̶0̶a̶1̶ ̶?̶

Nevermind, it's because pypy3 still uses Python 3.6

leszekhanusz avatar Sep 24 '22 22:09 leszekhanusz

@leszekhanusz is this PR ready to ship? I'd love to get a new release of gql with a setup.py version bump of graphql-core that allows 3.3 to work (https://github.com/graphql-python/gql/blob/master/setup.py#L6).

danvendia avatar Nov 07 '22 05:11 danvendia

@leszekhanusz is this PR ready to ship? I'd love to get a new release of gql with a setup.py version bump of graphql-core that allows 3.3 to work (https://github.com/graphql-python/gql/blob/master/setup.py#L6).

graphql-core 3.3 is still in alpha. I was thinking about waiting until a stable graphql-core release before merging this PR and making a new gql release.

But we could make a gql pre-release.

@Cito What do you think, should I make a gql pre-release 3.5.0a0 ?

leszekhanusz avatar Nov 07 '22 20:11 leszekhanusz

@leszekhanusz is this PR ready to ship? I'd love to get a new release of gql with a setup.py version bump of graphql-core that allows 3.3 to work (https://github.com/graphql-python/gql/blob/master/setup.py#L6).

graphql-core 3.3 is still in alpha. I was thinking about waiting until a stable graphql-core release before merging this PR and making a new gql release.

But we could make a gql pre-release.

@Cito What do you think, should I make a gql pre-release 3.5.0a0 ?

A pre-release of gql would be awesome if it makes sense 👍

danvendia avatar Nov 07 '22 21:11 danvendia

@Cito What do you think, should I make a gql pre-release 3.5.0a0 ?

That would be great, in order to find any incompatibilities and to test the new features in core 3.3.

Cito avatar Nov 07 '22 21:11 Cito

A pre-release of gql would be awesome if it makes sense +1

Pre-Release v3.5.0a0 is now available.

leszekhanusz avatar Nov 07 '22 22:11 leszekhanusz

Thanks so much @leszekhanusz! Really appreciate it

danvendia avatar Nov 07 '22 23:11 danvendia