flask-graphql icon indicating copy to clipboard operation
flask-graphql copied to clipboard

README: fix apollo-client link

Open sduthil opened this issue 4 years ago • 4 comments

sduthil avatar Apr 09 '20 14:04 sduthil

Coverage Status

Coverage remained the same at 93.548% when pulling 442b8b3d5d4b9cfeca4d3ba0b73fdd81388383b0 on sduthil:readme-apollo-client-link into 9691bafb6d98405cf0b283dbb272ad690b643643 on graphql-python:master.

coveralls avatar Apr 09 '20 14:04 coveralls

Coverage Status

Coverage remained the same at 93.548% when pulling 88ae94237b06742c94d1e7f09d76e19e49ddd667 on sduthil:readme-apollo-client-link into 9691bafb6d98405cf0b283dbb272ad690b643643 on graphql-python:master.

coveralls avatar Apr 09 '20 14:04 coveralls

In fact, the Apollo Client isn't only limited to React as there is one for Angular too and so on.

If you check the docs, you will see that it points to another guide at the following link for:

I think the first one is more generalized and not bound to a specific frontend framework.

Cheers!

KingDarBoja avatar Apr 13 '20 22:04 KingDarBoja

In fact, the Apollo Client isn't only limited to React as there is one for Angular too and so on.

If you check the docs, you will see that it points to another guide at the following link for:

* React: [batch-http](https://www.apollographql.com/docs/link/links/batch-http/)

* Angular: [angular-link-http-batch](https://github.com/apollographql/apollo-angular/tree/master/packages/apollo-angular-link-http-batch)

I think the first one is more generalized and not bound to a specific frontend framework.

Agreed that the doc should be as frontend-agnostic as possible. But IMHO the paragraph about query batching in the React section:

  • does not mention React
  • links to the detailed, agnostic documentation
  • gives a good example of using query batching, which I found very useful while learning GraphQL

sduthil avatar Apr 14 '20 13:04 sduthil