graphql-voyager icon indicating copy to clipboard operation
graphql-voyager copied to clipboard

disble mouse scroll

Open marchenko1985 opened this issue 1 year ago • 1 comments

Here is accompanying pull request that closes #436 feature request

TLDR:

provide disable mouse scroll setting

motivation: for a use cases when Voyager is just a part of bigger page, its current behavior brakes page scroll experience

notes:

  • new setting by intent named in this way so it is backward compatibe, opt-in
  • by intent other settings were not touched, but may be exposed as well when needed
  • did tried to keep changes as small as possible so did not changed anything unrelevant

marchenko1985 avatar Jan 01 '25 06:01 marchenko1985

Unfortunately there is an issue with one of the tests

Error:  |     Error: [ERROR] at 'http://serve-webpack-example:9090/?:0': Access to fetch at 'https://swapi-graphql.netlify.app/.netlify/functions/index' from origin 'http://serve-webpack-example:9090' has been blocked by CORS policy: No 'Access-Control-Allow-Origin' header is present on the requested resource. If an opaque response serves your needs, set the request's mode to 'no-cors' to fetch the resource with CORS disabled.

Notes:

  1. endpoint is not working at moment (trying to open https://swapi-graphql.netlify.app i see white page)
  2. it responds with 301 to /graphql and if we call it directly we receive 415
  3. there is https://graphql.org/swapi-graphql/ but under the hood it calls same endpoint and does not work as well

having that in place, not sure if I can fix this without making more changes that needed for this feature

marchenko1985 avatar Jan 01 '25 07:01 marchenko1985