handler icon indicating copy to clipboard operation
handler copied to clipboard

Published 20 hours ago • verified publisher icon graphql-go

Handle mutlipart/form-data

Open koblas opened this issue 6 years ago • 8 comments

This PR should support Multipart form-data file upload requests as specified by https://github.com/jaydenseric/graphql-multipart-request-spec -- which is adopted by the Apollo team. It also works without file uploads as a general handler.

koblas avatar Aug 01 '18 18:08 koblas

Coverage Status

Coverage increased (+2.6%) to 89.231% when pulling 5f3718a5f7508849cc33648407e5022030bb6887 on koblas:master into 59006c0464d5638788d7b0051ea5c959e0d84253 on graphql-go:master.

coveralls avatar Aug 01 '18 18:08 coveralls

@chris-ramon Nudge - would it be possible to have this looked at?

koblas avatar Aug 21 '18 17:08 koblas

hi all, When will it merge to master ?

duong-se avatar Oct 08 '18 02:10 duong-se

@chris-ramon Any chance that this could get a review, will clean up the conflict shortly.

koblas avatar Oct 08 '18 14:10 koblas

@koblas conflicts

appleboy avatar Dec 09 '18 15:12 appleboy

@appleboy Conflicts resolved... Hopefully, someday @chris-ramon will feel like merging.

koblas avatar Dec 10 '18 14:12 koblas

Can we merge this?

danjenson avatar Jan 22 '20 19:01 danjenson

While waiting this being merged, found an alternative handler supporting mutlipart/form-data created by @asif-mahmud.

Originally posted at https://github.com/graphql-go/graphql/issues/607 Library is at https://github.com/asif-mahmud/gingraphql

Just provide one more option 😃

hongbo-miao avatar Aug 28 '21 23:08 hongbo-miao