handler icon indicating copy to clipboard operation
handler copied to clipboard

Allow custom endpoint URL.

Open kivutar opened this issue 7 years ago • 9 comments

Attempt to address https://github.com/graphql-go/handler/issues/31 Websocket subscriptions are now working.

kivutar avatar Jan 03 '18 06:01 kivutar

Coverage Status

Coverage increased (+0.2%) to 87.5% when pulling 593f69e16a26c4e8126b5b88c85821a28569065a on Kivutar:master into cc93f95bb535278ff64b1c5ead653bdf9ca17d57 on graphql-go:master.

coveralls avatar Jan 03 '18 07:01 coveralls

Coverage Status

Coverage decreased (-1.4%) to 85.876% when pulling 69f77bc6e27e0af28cd49c0c4ae0e69f67589e3a on Kivutar:master into cc93f95bb535278ff64b1c5ead653bdf9ca17d57 on graphql-go:master.

coveralls avatar Jan 03 '18 08:01 coveralls

Coverage Status

Coverage decreased (-1.4%) to 85.876% when pulling 69f77bc6e27e0af28cd49c0c4ae0e69f67589e3a on Kivutar:master into cc93f95bb535278ff64b1c5ead653bdf9ca17d57 on graphql-go:master.

coveralls avatar Jan 03 '18 08:01 coveralls

Coverage Status

Coverage decreased (-1.5%) to 85.795% when pulling aace1d0670ea207d6add51be748938fc66e7b07f on Kivutar:master into cc93f95bb535278ff64b1c5ead653bdf9ca17d57 on graphql-go:master.

coveralls avatar Jan 05 '18 08:01 coveralls

Coverage Status

Coverage decreased (-1.5%) to 85.795% when pulling aace1d0670ea207d6add51be748938fc66e7b07f on Kivutar:master into cc93f95bb535278ff64b1c5ead653bdf9ca17d57 on graphql-go:master.

coveralls avatar Jan 05 '18 08:01 coveralls

Thanks for your reviews.

If I use a pointer for GraphiQLConfig I have to handle too many pointer dereferences in order to access the values. (I'm a golang beginner)

And if I use a plain struct, my changes are not consistent anymore with the current code, as handler.Config is a pointer.

What should I do?

kivutar avatar Jan 05 '18 08:01 kivutar

Coverage Status

Coverage decreased (-1.5%) to 85.795% when pulling d34f10521ea363ae6b1a7f934d3ca295da4daa7b on Kivutar:master into cc93f95bb535278ff64b1c5ead653bdf9ca17d57 on graphql-go:master.

coveralls avatar Jan 05 '18 08:01 coveralls

Coverage Status

Coverage decreased (-1.5%) to 85.795% when pulling 90414232e1fef563b21c94e50d61cf35838ff6f0 on Kivutar:master into cc93f95bb535278ff64b1c5ead653bdf9ca17d57 on graphql-go:master.

coveralls avatar Jan 05 '18 10:01 coveralls

@kivutar What's the status on this one ? I'd be really interested in having this feature available. :smile:

ccamel avatar May 11 '18 16:05 ccamel