graphql icon indicating copy to clipboard operation
graphql copied to clipboard

Published 20 hours ago • verified publisher icon graphql-go

Adopt idiomatic error handling for executor.

Open zonr opened this issue 5 years ago • 6 comments

Stop using panic/recover to throw errors. Instead, stick to Go's style for handling error. Function reports errors by returning an Go's error value (instead of passing with panic). Errors are explicitly checked or bypassed at where they might occur (instead of checking the return value from recover).

Discussion: #28 Related: #44 Invalidate: #243, #253 Close: #402

zonr avatar Oct 16 '18 10:10 zonr

What's preventing this from being merged?

atombender avatar Apr 03 '19 00:04 atombender

@egonelbre Could you take a look at this?

Fontinalis avatar Apr 03 '19 16:04 Fontinalis

Can this get some attention?

atombender avatar May 17 '19 16:05 atombender

@Fontinalis @egonelbre What's left for this to be merged? It's been 7 months, and this is bugging us.

atombender avatar Jun 03 '19 22:06 atombender

@Fontinalis I made the readability changes I commented in https://github.com/egonelbre/graphql/commit/3e383bec6e59522df4bed6219cf4f2ae11c0fe73, but I have no clue how to get these changes into this PR.

We could always merge as is and I can a do separate PR against.

egonelbre avatar Jun 05 '19 13:06 egonelbre

How long time we must wait to this feature?

jpascal avatar Jul 11 '20 13:07 jpascal