graphql executor: adds support for anonymous contained structs

executor: adds support for anonymous contained structs

Open chris-ramon opened this issue 5 years ago • 15 comments

Overview

Built on top of: https://github.com/graphql-go/graphql/pull/274
closes: https://github.com/graphql-go/graphql/issues/170

Test plan

go test ./...

Jul 28 '18 17:07 chris-ramon

HI, wondering if there is any chance to merge this?

Sep 14 '18 05:09 imjma

@chris-ramon @pavelnikolov Same question, would you please merge it?

Oct 19 '18 22:10 mrg0lden

Same here

Oct 22 '18 20:10 niondir

Thanks for letting us know how important this PR are for you guys.

I'll jump back to get this merge as soon as I get the chance today/tomorrow.

Oct 22 '18 20:10 chris-ramon

Coverage increased (+0.009%) to 91.787% when pulling d35d558066e2ec602528a5db16f29e9cd06173de on anon-contained-struct into a7e15c0298411af18c694ca387e733acef287104 on master.

Oct 24 '18 00:10 coveralls

I think this will resolve the issue without using user-provided resolve function.

if typeField.Anonymous && typeField.Type.Kind() == reflect.Struct {
  anonymousResolvedValue, err := defaultResolveStruct(valueField, fieldName)
  if err != nil {
    return nil, err
  } else if anonymousResolvedValue != nil {
    return anonymousResolvedValue, nil
  }
}