relay icon indicating copy to clipboard operation
relay copied to clipboard

Remove clientMutationId and use React Spa Template for .NET 6

Open fiyazbinhasan opened this issue 4 years ago • 8 comments

@Shane32 I just made some changes based on this issue, https://github.com/graphql-dotnet/relay/issues/106

fiyazbinhasan avatar Jul 16 '21 07:07 fiyazbinhasan

.NET 6 has not been released yet. Is there so much difference that we cannot use the .NET 5 server for the SPA? It should be fine if the SPA itself is based on the .NET 6 template.

Shane32 avatar Jul 19 '21 22:07 Shane32

It looks like .NET 6 is scheduled for release in November. Not that far away.

Shane32 avatar Jul 19 '21 22:07 Shane32

Hi @Shane32! Only the todo spa app is based on .net 6. I think it is far easier to use this template than to manage the react app yourself (webpack). What do you think?

fiyazbinhasan avatar Jul 19 '21 22:07 fiyazbinhasan

Certainly don’t want to manage the spa setup but if the .NET csproj targets .NET 5 rather than .NET 6 most likely everything else (such as create-react-app, which does the webpack setup) can stay the same.

Shane32 avatar Jul 20 '21 00:07 Shane32

Microsoft.AspNetCore.SpaProxy API is part of .NET 6. I can come back here later and update the todo app if anything breaks or we can wait till November

fiyazbinhasan avatar Jul 20 '21 04:07 fiyazbinhasan

Sounds fine. I can't push an updated package to nuget anyway. See #110

Shane32 avatar Jul 20 '21 13:07 Shane32

Sounds fine. I can't push an updated package to nuget anyway. See #110

Fixed

Shane32 avatar Jul 20 '21 14:07 Shane32

Finally! 🚀

fiyazbinhasan avatar Jul 20 '21 18:07 fiyazbinhasan