parser icon indicating copy to clipboard operation
parser copied to clipboard

Handle whitespaces somehow

Open sungam3r opened this issue 10 months ago • 3 comments

@my @your instead of @my @your now. It could be fixes as well checking parent node but for directives parent is always not null - it is Directives container, so actually grand parent is needed. Moreover, even after such check some tests failed (see Printer_Should_Print_Pretty_If_Directives_Skipped). The core problem is that some arbitrary nodes can be skipped so it's not obvious how to handle whitespaces at all. General approach may be to require each node to print their leading whitespace if it should do that. Downside - it will complicate all printing code. I do not want to do that just to handle very rare cases.

Originally posted by @sungam3r in https://github.com/graphql-dotnet/parser/pull/359#discussion_r1360220872

sungam3r avatar Oct 16 '23 07:10 sungam3r