conventions icon indicating copy to clipboard operation
conventions copied to clipboard

GraphQL7

Open SimonCropp opened this issue 2 years ago • 1 comments

SimonCropp avatar Aug 16 '22 04:08 SimonCropp

What's the status of this PR? Are there still tasks open? Anything I could help with?

floge07 avatar Sep 20 '22 06:09 floge07

@sungam3r & @Shane32 ping ;)

BoBiene avatar Nov 10 '22 13:11 BoBiene

@tlil Can you review, merge and publish? I can't publish.

If you like, you can set up a NuGet 'team', move the package to the team, and share access to me. Then I can download the NuGet API keys, configure a repo secret, configure a publish GitHub Action workflow, and then all of us maintainers can publish a new version with a couple clicks directly from GitHub, as we do in the other repos. It will also allow me to update the API key annually.

Shane32 avatar Nov 10 '22 14:11 Shane32

@tlil Can you review, merge and publish? I can't publish.

Will do.

If you like, you can set up a NuGet 'team', move the package to the team, and share access to me. Then I can download the NuGet API keys, configure a repo secret, configure a publish GitHub Action workflow, and then all of us maintainers can publish a new version with a couple clicks directly from GitHub, as we do in the other repos. It will also allow me to update the API key annually.

👍

tlil avatar Nov 10 '22 19:11 tlil

@Shane32 note that it's being published to NuGet from AppVeyor at the moment, so moving it all over to GitHub Actions as you suggested would be fab! :-) Will bump and tag this as 7.0.0 now and circle back on setting up a NuGet team and moving the package hopefully later today. Thanks!

tlil avatar Nov 11 '22 08:11 tlil

CleanShot 2022-11-11 at 20 07 32 @Shane32 - can you ping me your NuGet username, and I'll get you added to the NuGet Org that's now listed as the sole package owner?

tlil avatar Nov 11 '22 20:11 tlil

It's Shane32

https://www.nuget.org/profiles/Shane32

Shane32 avatar Nov 11 '22 20:11 Shane32

Thanks - I'll set up the publish script over this weekend.

Shane32 avatar Nov 11 '22 20:11 Shane32

Perhaps you can disconnect Appveyor when I'm done.

Shane32 avatar Nov 11 '22 20:11 Shane32

Perhaps you can disconnect Appveyor when I'm done.

Yep sounds good. Just gimme a shout when you've got the other pieces in place. Thanks!

tlil avatar Nov 11 '22 20:11 tlil

I have not forgotten btw, just not got to it yet.

Shane32 avatar Nov 22 '22 13:11 Shane32