mission-control-indexer icon indicating copy to clipboard operation
mission-control-indexer copied to clipboard

Don't need request to approve to spend GRT many times.

Open suntzu93 opened this issue 4 years ago • 5 comments

I notice that each time I submit a transaction I must approve. I think just request to approve the first time to avoid wasting fee and time.

Screen Shot 2020-09-14 at 11 42 50

suntzu93 avatar Sep 14 '20 04:09 suntzu93

Good feedback @suntzu93 ! We are working on improving this experience, it's in the pipeline

nenadjaja avatar Sep 15 '20 02:09 nenadjaja

I can finally get to this. Thanks for your patience, I know several ppl reported this. What would be a good amount to approve once, so we don't show it again? Like all the GRT a person has in their wallet? Cc @abarmat and @cryptovestor21 :)

nenadjaja avatar Oct 14 '20 18:10 nenadjaja

I've seen in many dapps that they do infinite approvals. Also a user can change the approval amount manually from Metamask before sending the transaction so we can check if the user already has allowance to avoid showing the approval popup in those cases.

abarmat avatar Oct 14 '20 18:10 abarmat

Yeah it's easy to check. I guess the question is "how much should we pre-approve" or should we assume if a user has pre-approved once, they are good to go for any amount?

nenadjaja avatar Oct 14 '20 19:10 nenadjaja

I also just saw, if you want to make a signal to a subgraph, you first have to approve it and then you are automatically forwarded to the second transaction. But if you are approved and do not use the automatic redirection directly but reload the page again, the approve transaction will come again. Here the second transaction should come directly.

WayneWayner avatar Oct 19 '20 07:10 WayneWayner