indexer icon indicating copy to clipboard operation
indexer copied to clipboard

feat: Deployment tags to replace `indexer-agent` prefix in deployment names

Open datanexus-vincent opened this issue 1 year ago • 3 comments

Indexers need an easy way to deploy to different shards and graph-nodes. This is already possible with graph-node alone via deployment rules and deployment name regex matching, but the indexer-agent doesn't give any way to control the name that a deployment is given. With this PR, I've introduced a tag column for indexing rules, whose contents will replace the indexer-agent prefix for deployment names upon first deployment.

With a combination of a deployment rule like this:

[[deployment.rule]]
match = { name = "(vip|important)/.*", network = "arbitrum-one" }
shard = "arbitrum_vip"
indexers = [ "graph_node_vip_0", "graph_node_vip_1" ]

and a tag set like this:

graph indexer rules set QmHash decisionBasis offchain tag vip

You can now deploy VIP arbitrum subgraphs to your arbitrum VIP database directly.

Feel free to request or make changes. I'll do my best to satisfy any requirements so we can get this merged.

datanexus-vincent avatar Jun 22 '24 18:06 datanexus-vincent

Love this idea, @datanexus-vincent! 🙌

We'll also need some way of representing this in the actions queue so that deployments created/deployed through that flow can have tags applied too. I'll take a closer look at how to make that addition and see if we can get this in next week.

fordN avatar Jul 12 '24 18:07 fordN

@fordN Is there any plan to implement this yet?

suntzu93 avatar Sep 04 '24 00:09 suntzu93

Gentle nudge from me too 👀

trader-payne avatar Oct 30 '24 20:10 trader-payne