graph-node icon indicating copy to clipboard operation
graph-node copied to clipboard

[Feature] Declarative Calls Feedback

Open melotik opened this issue 8 months ago • 4 comments

Description

I spent some time trying to add declarative calls (https://github.com/graphprotocol/graph-node/pull/5264) to messari's compound v3 subgraph as it uses a lot of eth_calls. I wasn't able to fully test any of this yet due to this blocker (https://github.com/graphprotocol/graph-node/issues/5444), however I had some feedback or requests for use cases that showed up when I was working to cut over the subgraph to use declarative calls.

  • Using an eth_call as input for another eth_call, here is a real example:
const utilization = cometContract.getUtilization();
const borrowRate = cometContract.getBorrowRate(utilization).toBigDecimal();
const supplyRate = cometContract.getSupplyRate(utilization).toBigDecimal();
  • Multiple calls on one handler for the same function call with different input:
calls:
	Comet.totalsBasic: Comet[event.address].totalsBasic(event.params.liquidator)
	Come.totalsBasic: Comet[event.address].totalsBasic(event.params.borrower)

Note: This may be possible to do already, but I am not sure

Are you aware of any blockers that must be resolved before implementing this feature? If so, which? Link to any relevant GitHub issues.

https://github.com/graphprotocol/graph-node/issues/5444

Some information to help us out

  • [ ] Tick this box if you plan on implementing this feature yourself.
  • [X] I have searched the issue tracker to make sure this issue is not a duplicate.

melotik avatar May 28 '24 15:05 melotik