graph-client icon indicating copy to clipboard operation
graph-client copied to clipboard

[Improvement request] Critical dependency: the request of a dependency is an expression

Open matthewlilley opened this issue 3 years ago • 7 comments

We use the generated SDK within multiple Next.js applications, and are seeing a lot of these messages.

Screenshot_62

How can these be avoided?

matthewlilley avatar Oct 25 '22 20:10 matthewlilley

Are they preventing you to build the client? If no, you can ignore it.

ardatan avatar Oct 25 '22 20:10 ardatan

@ardatan No, not at all. It's more of a nausiance. It clogs up terminal so makes debugging a little difficult.

matthewlilley avatar Oct 25 '22 23:10 matthewlilley

It depends on your bundler. You can check the bundler's documentation for that.

ardatan avatar Oct 26 '22 22:10 ardatan

I think this should be resolved on this end, and think this issue should stay open. Out of thousands of packages, the graph client is the only one which does this. Ignoring via webpack is an option but is a workaround rather than a real solution.

matthewlilley avatar Jun 14 '23 06:06 matthewlilley

Ok I'm reopening it but this is not a bug definitely. This has 0 effect on runtime or it doesn't block you from building the project. Maybe we'll find a way to get rid of these false warnings from webpack.

ardatan avatar Jun 22 '23 15:06 ardatan

I have the same issue, does anyone know how to configure Webpack so that this warning goes away?

pugbyte avatar Jun 28 '23 03:06 pugbyte

Same issue here, and also interested in webpack configuration :)

LilaRest avatar Jul 06 '23 13:07 LilaRest