contracts icon indicating copy to clipboard operation
contracts copied to clipboard

feat: update some contracts to use solidity 0.8

Open pcarranzav opened this issue 3 years ago • 2 comments
trafficstars

experimental / WIP, take this with a bucketful of salt, might not work, etc

pcarranzav avatar Sep 29 '22 20:09 pcarranzav

Socket Security Report

Dependency issues detected. If you merge this pull request, you will not be alerted to the instances of these issues again.

📜 New install scripts detected

A dependency change in this PR is introducing new install scripts to your install step.

Package Script field Location
[email protected] (added) binding.gyp package.json via @nomicfoundation/[email protected], [email protected]
[email protected] (added) install package.json via @nomicfoundation/[email protected], [email protected]
[email protected] (upgraded) postinstall package.json
🫣 Native code

Contains native code which could be a vector to obscure malicious code, and generally decrease the likelihood of reproducible or reliable installs.

Package Location
[email protected] (added) package.json via @nomicfoundation/[email protected], [email protected]
😵‍💫 Bin script confusion

This package has multiple bin scripts with the same name. This can cause non-deterministic behavior when installing or could be a sign of a supply chain attack.

Package Bin script Location
@nomicfoundation/[email protected] (added) rlp package.json
[email protected] (added) rlp package.json via [email protected], @ethereum-waffle/[email protected], [email protected], [email protected]
[email protected] (added) rlp package.json
Socket.dev scan summary
Issue Status
Did you mean? ✅ no new possible package typos
Install scripts ⚠️ 3 new install scripts detected
Telemetry ✅ no new telemetry
Troll package ✅ no new troll packages
Malware ✅ no new malware
Native code ⚠️ 1 new native module detected
Bin Script Confusion ⚠️ 3 new bin script confusions detected
Bin script shell injection ✅ no new bin script shell injection
Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore [email protected] [email protected]

Powered by socket.dev

socket-security[bot] avatar Sep 29 '22 20:09 socket-security[bot]

Codecov Report

Base: 91.56% // Head: 91.54% // Decreases project coverage by -0.02% :warning:

Coverage data is based on head (fc7120d) compared to base (263355d). Patch coverage: 88.97% of modified lines in pull request are covered.

Additional details and impacted files
@@                    Coverage Diff                    @@
##           pcv/l2-linear-rewards     #725      +/-   ##
=========================================================
- Coverage                  91.56%   91.54%   -0.03%     
=========================================================
  Files                         42       42              
  Lines                       2003     1998       -5     
  Branches                     350      350              
=========================================================
- Hits                        1834     1829       -5     
  Misses                       169      169              
Flag Coverage Δ
unittests 91.54% <88.97%> (-0.03%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
contracts/base/Multicall.sol 100.00% <ø> (ø)
contracts/curation/GraphCurationToken.sol 100.00% <ø> (ø)
contracts/discovery/ServiceRegistry.sol 100.00% <ø> (ø)
contracts/discovery/SubgraphNFTDescriptor.sol 100.00% <ø> (ø)
...ontracts/discovery/erc1056/EthereumDIDRegistry.sol 0.00% <ø> (ø)
contracts/gateway/BridgeEscrow.sol 100.00% <ø> (ø)
contracts/gateway/GraphTokenGateway.sol 100.00% <ø> (ø)
contracts/governance/Controller.sol 100.00% <ø> (ø)
contracts/governance/Governed.sol 100.00% <ø> (ø)
contracts/governance/GraphGovernance.sol 100.00% <ø> (ø)
... and 32 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Sep 29 '22 21:09 codecov[bot]