contracts
contracts copied to clipboard
refactor(L1Reservoir): split _drip into smaller functions and rename some variables
Split the _drip function into smaller pieces, hopefully making it cleaner and easier to understand.
We also rename mintedRewardsActual to lastDripRewardsUntilCurrentBlock, and mintedRewardsTotal to lastDripTotalRewards, hopefully making these closer to what they represent.
Codecov Report
:exclamation: No coverage uploaded for pull request base (
pcv/l2-drip-rewards@559ea00). Click here to learn what that means. Patch has no changes to coverable lines.
Additional details and impacted files
@@ Coverage Diff @@
## pcv/l2-drip-rewards #705 +/- ##
======================================================
Coverage ? 92.40%
======================================================
Files ? 45
Lines ? 2160
Branches ? 375
======================================================
Hits ? 1996
Misses ? 164
Partials ? 0
| Flag | Coverage Δ | |
|---|---|---|
| unittests | 92.40% <0.00%> (?) |
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
CI failed because of https://github.com/graphprotocol/contracts/issues/576 - retrying
Closing as GIP-0037 is believed to be the better alternative at this point (see https://forum.thegraph.com/t/gip-0037-the-graph-arbitrum-deployment-with-linear-rewards-minted-in-l2/3551)