contracts icon indicating copy to clipboard operation
contracts copied to clipboard

L2: drip rewards from L1, introducing Reservoirs

Open pcarranzav opened this issue 3 years ago • 1 comments
trafficstars

The changes from this PR correspond to GIP-0034

This is a rebased version of #571, cleaned up to only include the changes for the reservoir drip rewards distribution mechanism. Rebased on top of #699 which includes the bridge with all the audit fixes.

pcarranzav avatar Sep 01 '22 20:09 pcarranzav

Codecov Report

Base: 91.53% // Head: 92.34% // Increases project coverage by +0.80% :tada:

Coverage data is based on head (648f54d) compared to base (8aa3bd6). Patch coverage: 99.48% of modified lines in pull request are covered.

:exclamation: Current head 648f54d differs from pull request most recent head 559ea00. Consider uploading reports for the commit 559ea00 to get more accurate results

Additional details and impacted files
@@                Coverage Diff                @@
##           pcv/l2-bridge     #701      +/-   ##
=================================================
+ Coverage          91.53%   92.34%   +0.80%     
=================================================
  Files                 42       44       +2     
  Lines               1984     2141     +157     
  Branches             346      374      +28     
=================================================
+ Hits                1816     1977     +161     
+ Misses               168      164       -4     
Flag Coverage Δ
unittests 92.34% <99.48%> (+0.80%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
contracts/tests/ReservoirMock.sol 66.66% <66.66%> (ø)
contracts/governance/Managed.sol 100.00% <100.00%> (+5.45%) :arrow_up:
contracts/l2/reservoir/L2Reservoir.sol 100.00% <100.00%> (ø)
contracts/reservoir/L1Reservoir.sol 100.00% <100.00%> (ø)
contracts/reservoir/Reservoir.sol 100.00% <100.00%> (ø)
contracts/rewards/RewardsManager.sol 100.00% <100.00%> (ø)
contracts/staking/Staking.sol 96.77% <100.00%> (+0.48%) :arrow_up:
contracts/l2/gateway/L2GraphTokenGateway.sol 100.00% <0.00%> (ø)
contracts/tests/CallhookReceiverMock.sol

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Sep 01 '22 20:09 codecov[bot]

Closing as GIP-0037 is believed to be the better alternative at this point (see https://forum.thegraph.com/t/gip-0037-the-graph-arbitrum-deployment-with-linear-rewards-minted-in-l2/3551)

pcarranzav avatar Nov 23 '22 17:11 pcarranzav