contracts
contracts copied to clipboard
Query versioning for dispute resolution
Motivation
This change to the Dispute Manager is intended to allow multiple query attestation formats that involve different query versions as described in this GIP https://forum.thegraph.com/t/gip-0024-query-versioning/3145
Changes
- Add a
bytes32domainSeparator field to the attestation payload submitted on bothcreateQueryDisputeandcreateQueryDisputeConflict. - Use the passed domainSeparator to build the message hash used for recovering the signer.
- Deprecate the domain separator with fixed versioning from the contract storage.
These are still not consistent. Some end with
SIZE_LENGTHand some withLENGTH
Pushed once more, now we are fully consistent
Codecov Report
Merging #548 (a48c42d) into dev (3541624) will decrease coverage by
0.01%. The diff coverage is100.00%.
@@ Coverage Diff @@
## dev #548 +/- ##
==========================================
- Coverage 91.19% 91.18% -0.02%
==========================================
Files 37 37
Lines 1795 1792 -3
Branches 293 293
==========================================
- Hits 1637 1634 -3
Misses 158 158
| Flag | Coverage Δ | |
|---|---|---|
| unittests | 91.18% <100.00%> (-0.02%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Impacted Files | Coverage Δ | |
|---|---|---|
| contracts/disputes/DisputeManager.sol | 99.30% <100.00%> (-0.02%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 3541624...a48c42d. Read the comment docs.
This PR has become quite outdated and would need a big refactor to get merged. I'll close it and we can use it as a reference for a new PR if the corresponding proposal is reactivated.