contracts icon indicating copy to clipboard operation
contracts copied to clipboard

Query versioning for dispute resolution

Open abarmat opened this issue 3 years ago • 2 comments
trafficstars

Motivation

This change to the Dispute Manager is intended to allow multiple query attestation formats that involve different query versions as described in this GIP https://forum.thegraph.com/t/gip-0024-query-versioning/3145

Changes

  • Add a bytes32 domainSeparator field to the attestation payload submitted on both createQueryDispute and createQueryDisputeConflict.
  • Use the passed domainSeparator to build the message hash used for recovering the signer.
  • Deprecate the domain separator with fixed versioning from the contract storage.

abarmat avatar Mar 07 '22 14:03 abarmat

These are still not consistent. Some end with SIZE_LENGTH and some with LENGTH

Pushed once more, now we are fully consistent

abarmat avatar Mar 09 '22 15:03 abarmat

Codecov Report

Merging #548 (a48c42d) into dev (3541624) will decrease coverage by 0.01%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #548      +/-   ##
==========================================
- Coverage   91.19%   91.18%   -0.02%     
==========================================
  Files          37       37              
  Lines        1795     1792       -3     
  Branches      293      293              
==========================================
- Hits         1637     1634       -3     
  Misses        158      158              
Flag Coverage Δ
unittests 91.18% <100.00%> (-0.02%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
contracts/disputes/DisputeManager.sol 99.30% <100.00%> (-0.02%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3541624...a48c42d. Read the comment docs.

codecov[bot] avatar Mar 11 '22 13:03 codecov[bot]

This PR has become quite outdated and would need a big refactor to get merged. I'll close it and we can use it as a reference for a new PR if the corresponding proposal is reactivated.

pcarranzav avatar Jan 17 '24 13:01 pcarranzav