launchpad-charts icon indicating copy to clipboard operation
launchpad-charts copied to clipboard

feat: change default accessMode to ReadWriteOncePod

Open cjorge-graphops opened this issue 1 year ago • 2 comments

This is a breaking change in the sense an existing STS can't be updated, so users need to either add an accessMode override to keep as is (assuming they were using the default ReadWriteOnce), or go through the hoops to recreate their STS themselves

Summary by CodeRabbit

Release Notes

  • New Features

    • Incremented chart versions for multiple components, indicating new releases.
  • Configuration Changes

    • Updated accessModes from ["ReadWriteOnce"] to ["ReadWriteOncePod"] across various charts, enhancing volume access capabilities for pods.
  • Documentation Updates

    • Version updates reflected in README files for all affected charts, ensuring users are aware of the latest changes and configurations.

cjorge-graphops avatar Oct 28 '24 09:10 cjorge-graphops

Walkthrough

The pull request introduces version updates and configuration changes across multiple Helm charts, including arbitrum-classic, arbitrum-nitro, celo, erigon, heimdall, lighthouse, nimbus, and subgraph-radio. Each chart's version is incremented to a new release, and the accessModes for volumeClaimSpec is modified from ReadWriteOnce to ReadWriteOncePod, allowing for different access patterns for persistent volumes. Documentation in the README files is also updated to reflect these changes.

Changes

File Path Change Summary
charts/arbitrum-classic/Chart.yaml Version updated from 0.2.1 to 0.3.0.
charts/arbitrum-classic/README.md Version updated from 0.2.1 to 0.3.0; accessModes changed from ReadWriteOnce to ReadWriteOncePod.
charts/arbitrum-classic/values.yaml accessModes updated from ["ReadWriteOnce"] to ["ReadWriteOncePod"].
charts/arbitrum-nitro/Chart.yaml Version updated from 0.5.1 to 0.6.0.
charts/arbitrum-nitro/README.md Version updated from 0.5.1 to 0.6.0; accessModes changed from ReadWriteOnce to ReadWriteOncePod.
charts/arbitrum-nitro/values.yaml accessModes updated from ["ReadWriteOnce"] to ["ReadWriteOncePod"].
charts/celo/Chart.yaml Version updated from 0.1.7 to 0.2.0.
charts/celo/README.md Version updated from 0.1.7 to 0.2.0; accessModes changed from ReadWriteOnce to ReadWriteOncePod.
charts/celo/values.yaml accessModes updated from ["ReadWriteOnce"] to ["ReadWriteOncePod"].
charts/erigon/Chart.yaml Version updated from 0.10.7 to 0.11.0.
charts/erigon/README.md Version updated from 0.10.7 to 0.11.0; accessModes changed from ReadWriteOnce to ReadWriteOncePod.
charts/erigon/values.yaml accessModes updated from ["ReadWriteOnce"] to ["ReadWriteOncePod"].
charts/heimdall/Chart.yaml Version updated from 1.2.4 to 1.3.0.
charts/heimdall/README.md Version updated from 1.2.4 to 1.3.0; accessModes changed from ReadWriteOnce to ReadWriteOncePod.
charts/heimdall/values.yaml accessModes updated from ["ReadWriteOnce"] to ["ReadWriteOncePod"].
charts/lighthouse/Chart.yaml Version updated from 0.5.10 to 0.6.0.
charts/lighthouse/README.md Version updated from 0.5.10 to 0.6.0; accessModes changed from ReadWriteOnce to ReadWriteOncePod.
charts/lighthouse/values.yaml accessModes updated from ["ReadWriteOnce"] to ["ReadWriteOncePod"].
charts/nimbus/Chart.yaml Version updated from 0.5.18 to 0.6.0.
charts/nimbus/README.md Version updated from 0.5.18 to 0.6.0; accessModes changed from ReadWriteOnce to ReadWriteOncePod.
charts/nimbus/values.yaml accessModes updated from ["ReadWriteOnce"] to ["ReadWriteOncePod"].
charts/subgraph-radio/Chart.yaml Version updated from 0.2.14 to 0.3.0.
charts/subgraph-radio/README.md Version updated from 0.2.14 to 0.3.0; accessModes changed from ReadWriteOnce to ReadWriteOncePod.
charts/subgraph-radio/values.yaml accessModes updated from ["ReadWriteOnce"] to ["ReadWriteOncePod"].
charts/lib/README.md New README file created for the Helm chart library.
charts/test-chart/README.md New README file created for the test-chart.

Possibly related PRs

  • #355: The changes in this PR involve updates to the values.yaml file, specifically adding a genesis.json configuration, which is related to the management of persistent volume claims and access modes, similar to the changes made in the main PR regarding accessModes in the values.yaml file for the Arbitrum chart.

Suggested reviewers

  • calinah
  • i0n

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar Oct 28 '24 09:10 coderabbitai[bot]

Putting this on-hold until we sort out the issue encountered with ReadWriteOncePod and initial volume permissions

cjorge-graphops avatar Nov 06 '24 21:11 cjorge-graphops