Confusing error message when posting incorrect data arity

[ef4]

If you accidentally POST { data: [{}] } instead of { data: {} } to a typical create endpoint that does MyResource.build(params), graphiti errors with:

TypeError (no implicit conversion of Symbol into Integer)

This seems like an opportunity to validate the structure earlier and give a better error message.

[richmolj]

I definitely agree we should validate earlier and give a better error message. Another semi-common use case is accidentally nesting included inside data, instead of the same level.

We do have a request validator but it's called too late in these cases. We've also depended on open-source libs for this in the past, but since Graphiti extends JSON:API they haven't worked out.

Working on another project at the moment but will prioritize when I switch back. Unless you (or anyone reading) would like to PR!

(BTW - liquid-fire was one of the things that attracted me to Ember when I had the chance to use it a few years ago, that eventually led to JSON:API usage and then this project. Full circle! Cheers! ❤️ )

[johnmosesman]

Ran into this as well with the side-posting data format.

For posterity the correct structure for creating "user and posts" is:

{
  data: {
    type: "users",
    attributes: {
      name: "New User",
      email: "[email protected]",
      ...
    },
    relationships: {
      posts: {
        data: [
          { :'temp-id' => 'abc123', type: 'posts', method: 'create' }
        ]
      }
    }
  },
  included: [
    {
      :'temp-id' => "abc123",
      type: "posts",
      attributes: {
        title: 'Some Post',
        body: "Here is the post"
        ...
      }
    }
  ]
}

Note relationships is inside the data attribute, but included is a top-level element.