whisper icon indicating copy to clipboard operation
whisper copied to clipboard

Fix whisper-fetch.py --drop timestamps

Open cdeil opened this issue 3 years ago • 3 comments

Possible fix for #305 .

I didn't test this, not sure if this is correct.

Specifically I don't know how timestamps and offsets in Whisper files work. Is a simple t + step appropriate, or is taking into account an offset and wrap-around needed?

cdeil avatar Nov 12 '20 12:11 cdeil

this should work, the wraparounds are handled by whisper.py

piotr1212 avatar Nov 12 '20 12:11 piotr1212

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jan 12 '21 00:01 stale[bot]

Sorry, forgot about this.

This is definitely an improvement over the current situation, but the json part is still incorrect as it removes values but does not even have a timestamp, there is no way to know which timestamps have been removed.

@cdeil did you have time to test this?

piotr1212 avatar Jan 12 '21 08:01 piotr1212