graphite-web icon indicating copy to clipboard operation
graphite-web copied to clipboard

Consolidate `add` and `offset` functions

Open Felixoid opened this issue 3 years ago • 4 comments

Is your feature request related to a problem? Please describe. As I see and discuss with @dzhdanov, add and offset are pretty much the same functions with different descriptions and small implementation details.

Describe the solution you'd like One function should be an alias to another with only one implementation

Describe alternatives you've considered The alternative would be to leave it as it is, but now it doesn't look good, even from the documentation side: add vs offset

Felixoid avatar Jan 20 '21 11:01 Felixoid

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Mar 21 '21 20:03 stale[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Dec 31 '22 22:12 stale[bot]

Is it still the case?

Felixoid avatar Jan 02 '23 10:01 Felixoid

I think so. Pinned.

deniszh avatar Jan 02 '23 13:01 deniszh