graphite-web icon indicating copy to clipboard operation
graphite-web copied to clipboard

Replace charged language "whitelist/blacklist"

Open obfuscurity opened this issue 9 years ago • 4 comments

This PR replaces #1570, fixing a merge conflict.

Addressing https://github.com/graphite-project/graphite-web/issues/1569

Related to https://github.com/graphite-project/carbon/issues/567 / https://github.com/graphite-project/carbon/pull/568

obfuscurity avatar Sep 15 '16 16:09 obfuscurity

Current coverage is 65.61% (diff: 95.23%)

Merging #1700 into master will not change coverage

@@             master      #1700   diff @@
==========================================
  Files            54         54          
  Lines          6122       6122          
  Methods           0          0          
  Messages          0          0          
  Branches       1210       1210          
==========================================
  Hits           4017       4017          
  Misses         1892       1892          
  Partials        213        213          

Powered by Codecov. Last update 20d443b...a32b395

codecov-io avatar Sep 15 '16 17:09 codecov-io

I'm pushing this back to the next milestone for now. I would like to see this go in but after working on it for a day I feel like there's room for improvement in terms of naming clarity. I've gone through it a few times and caught myself getting confused with some of the functions/settings.

obfuscurity avatar Sep 16 '16 20:09 obfuscurity

refs https://github.com/graphite-project/carbon/pull/591

obfuscurity avatar Sep 16 '16 20:09 obfuscurity

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Apr 13 '20 20:04 stale[bot]