feat(api)!: remove legacy API v1/VGraph support
BREAKING CHANGE: Remove legacy VGraph/protobuf API v1 in favor of Arrow API v3.
Removed:
-
_etl1(),_etl_url(),_check_url()methods from pygraphistry.py - API v1 dispatch path from PlotterBase.py
-
TestPlotterBindings_API_1andTestPlotterStylesJSONtest classes
Changed:
-
register(api=...)type fromLiteral[1, 3]toLiteral[3] -
client_session.pytype fromLiteral["arrow", "vgraph"]toLiteral["arrow"]
Migration: Users calling graphistry.register(api=1) must switch to graphistry.register(api=3) or omit the parameter (defaults to v3).
5 files changed, 47 insertions(+), 361 deletions(-)
@aucahuasi ci red?
- does this default to API=3, or registers needs to be chang to do that too?
Yes, api=3 is defined in ClientSession.__init__()
- If someone calls plot without register, does that still error well?
Yes, with a clear Exception("Not logged in")
- I noticed a version checking code is removed, is that truly legacy?
Yes, that was for api=1 (aka only used for legacy)
- any API=1/2 calls left in docs/ipynb's?
Done, I updated this, see commit https://github.com/graphistry/pygraphistry/pull/865/commits/f2524e3193a8b37fd8d10bacc3726d56b0281590
@aucahuasi looks good --
- let's publish as a major (breaking), 0.47.0
- Maybe changelog.md can comment that graphistry version x.y.z+ no longer supports api=1/2 uploads
- update changelog for migration note to switch from old key system to JWT-based auth options in
register(): https://pygraphistry.readthedocs.io/en/latest/server/register.html , as that mean creds flow changes too