pygraphistry icon indicating copy to clipboard operation
pygraphistry copied to clipboard

Code garden: Review and address TODOs in PlotterBase.py

Open lmeyerov opened this issue 2 months ago • 0 comments

Background

During issue #801 review, we identified 5 TODO comments in PlotterBase.py that should be evaluated and either:

  • Implemented
  • Documented with rationale for not implementing
  • Removed if no longer relevant

TODOs to Review

Located in graphistry/PlotterBase.py:

  1. Line 864: #TODO check set to api=3? - API version validation
  2. Line 891: #TODO ensure that it is a color? - Color validation
  3. Line 2185: TODO related to encoding/bindings
  4. Line 2247: TODO related to encoding/bindings
  5. Line 2263: #TODO: should we hash just in case... - Optimization consideration

Tasks

  • [ ] Read each TODO and understand context
  • [ ] Determine if TODO is still relevant
  • [ ] For relevant TODOs: implement fix or document why not needed
  • [ ] Remove obsolete TODOs
  • [ ] Update tests if changes are made

Priority

Low priority - these are code quality improvements, not bugs.

Related Issues

  • #801 - Original issue where these TODOs were identified

🤖 Generated with Claude Code

lmeyerov avatar Oct 19 '25 02:10 lmeyerov