pygraphistry icon indicating copy to clipboard operation
pygraphistry copied to clipboard

make cuCat opt-in

Open lmeyerov opened this issue 2 years ago • 6 comments

To help mitigate risk, let's make cuCat opt-in

What should the interface be?

  • should work clearly with other opts
  • should work clearly with implicit featurize calls like .umap()
  • when we flip default to on, e.g., engine=cudf, should not be too painful to change

lmeyerov avatar Feb 20 '23 23:02 lmeyerov

i have added 'cucat' flag within feature_engine under cucat branch, so opt-in use case is set once installed from pip graphistry/cucat

dcolinmorgan avatar Feb 22 '23 04:02 dcolinmorgan

great, see my comments on the branch

lmeyerov avatar Feb 25 '23 22:02 lmeyerov

lingering torch_check question https://graphistry.slack.com/archives/C0487PGP96E/p1677633106428139

dcolinmorgan avatar Mar 03 '23 07:03 dcolinmorgan

including in issues we can close now/soon (?)

lmeyerov avatar Jul 23 '23 09:07 lmeyerov

the umap and feautize flags work well and independently. I believe this fulfills opt-in bullets at top

easy to swap in cu_cat down the road as default

dcolinmorgan avatar Aug 02 '23 12:08 dcolinmorgan

great let's close when https://github.com/graphistry/pygraphistry/pull/486 is ready to merge ! (see comments there)

lmeyerov avatar Aug 02 '23 16:08 lmeyerov