pygraphistry
pygraphistry copied to clipboard
[BUG] g.register(org_name) not functional in some cases
Describe the bug g.register() for various configurations are not working as expected.
To Reproduce Code, including data, than can be run without editing:
pip install git+https://github.com/graphistry/pygraphistry@org_sso_login --user
graphistry.__version__ #check to make sure branch version
graphistry.register(api=3, protocol="https", server="", username="", password=""), #works
graphistry.register(api=3, protocol="https", server="", username="", password="", token="") #works
graphistry.register(api=3, protocol="https", server="",username="", password="",idp_name="", token="") #works
graphistry.register(api=3, protocol="https", server="", username="", password="",idp_name="") #works
#the next g.register()'s do not work
graphistry.register(api=3, protocol="https", server="", token="") #doesnt work
graphistry.register(api=3, protocol="https", server="",username="", password="",org_name="", token="")#doesnt work
graphistry.register(api=3, protocol="https", server="", username="", password="",org_name="") #doesnt work
Expected behavior What should have happened
g.register() shouldve registered in all cases
Actual behavior
What did happen it didnt work in some cases
Screenshots
If applicable, any screenshots to help explain the issue
Browser environment (please complete the following information):
- OS: [e.g. iOS]
- Browser [e.g. chrome, safari] chrome latest
- Version [e.g. 22]
Graphistry GPU server environment
- Where run [e.g., Hub, AWS, on-prem] aws eks demo notebook
- If self-hosting, Graphistry Version [e.g. 0.14.0, see bottom of a viz or login dashboard]
- If self-hosting, any OS/GPU/driver versions
PyGraphistry API client environment
-
Where run [e.g., Graphistry 2.35.9 Jupyter] graphistry juypter
-
Version [e.g. 0.14.0, print via
graphistry.__version__
] '0.26.1+39.gec009c7' -
Python Version [e.g. Python 3.7.7]
-
python3.8
Additional context Add any other context about the problem here.
Looks like for bugs:
- [x] standalone token (no user/pass) -- lower priority bug
- [x] any use of org_name (!)
Interesting but maybe not a bug:
- idp defaults to personal org, not idp's org <-- this may count as a priv escalation?
Not tested (diff branch?): personal keys
(in testing)
org uploads work, i think the issue is sso, so moving projects