pygraphistry icon indicating copy to clipboard operation
pygraphistry copied to clipboard

[BUG] Personal org should not propagate to uploads

Open lmeyerov opened this issue 3 years ago • 1 comments

When register(api=3, username=..., password=...), with no org_name, the client<>server action gets confused on legacy pre-org servers

  • [x] the client should NOT send org_name to the server, e.g., it should NOT send org_name: None or org_name: <personalorg> <-- this seems to currently be confusing existing clients <> old servers
    • [x] arrow_uploader should record None for the org_name instead of not recording it: https://github.com/graphistry/pygraphistry/blob/322be2d30784842571cf9f087193d26c1e1633da/graphistry/arrow_uploader.py#L163
    • [x] api calls should drop key org_name when it is None, e.g., https://github.com/graphistry/pygraphistry/blob/322be2d30784842571cf9f087193d26c1e1633da/graphistry/arrow_uploader.py#L173
    • [x] audit: arrow_uploader, ArrowFileUploader (via as_files=True, called by plot() -> arrow_uploader), login
  • [x] instead, the server should autofill org = <users's default org> <--- File/Dataset via AccessControlModel seems to do org = self.author.organization, which is personal org, not default organization

lmeyerov avatar Jul 07 '22 00:07 lmeyerov

pygraphistry code fixed, push as fix_org_name_old_server last item which is for nexus server, fixed in org_sso_k8s_new

vaimdev avatar Jul 15 '22 15:07 vaimdev