graph-app-kit icon indicating copy to clipboard operation
graph-app-kit copied to clipboard

fix: change all docker-compose refs to docker compose and update python versions for CI

Open DataBoyTX opened this issue 7 months ago • 3 comments

  1. change all docker-compose refs to docker compose

  2. update python versions for CI from 3.7-3.9 to 3.10-3.13

DataBoyTX avatar Jun 10 '25 04:06 DataBoyTX

Thanks, well overdue

See comments, I think we need to:

  • Drop the compose installer / linker
  • Not edit file names like docker-compose.yml, just the commands

@lmeyerov: I confirmed by running a simple test that the amazon linux docker does not have the docker plugin, so we can either stick with docker-compose install as-is, or install from the official docker repo to get the latest w/ plugin. Let me know which path is preferred.

DataBoyTX avatar Jun 12 '25 01:06 DataBoyTX

What i mean is we don't need to do the extra aliasing step of linking of bin/docker-compose to some install

I'm unsure if install docker installs 'docker compose' or we need to tell it explicitly as part of that - I think installing docker gets you compose too, so we can skip the explicit download of compose as well, if a modern docker

graphistry and Louie host scripts are probably good refs of how to do, guessing these are OSS'd variants of those

lmeyerov avatar Jun 12 '25 04:06 lmeyerov

What i mean is we don't need to do the extra aliasing step of linking of bin/docker-compose to some install

I'm unsure if install docker installs 'docker compose' or we need to tell it explicitly as part of that - I think installing docker gets you compose too, so we can skip the explicit download of compose as well, if a modern docker

graphistry and Louie host scripts are probably good refs of how to do, guessing these are OSS'd variants of those

I tried several variations to get it work, but I don't think it's possible on AL2. Amazon Linux 2 EOL was extended to June 2026, so we might want to consider moving to version 3 now, otherwise we'll likely be revisiting this PR a year from now.

DataBoyTX avatar Jun 13 '25 02:06 DataBoyTX