graphile-engine icon indicating copy to clipboard operation
graphile-engine copied to clipboard

Backport V5 test system to V4

Open benjie opened this issue 3 years ago • 2 comments

Description

V5's test system is much more pleasant than V4's; but I'd like to bring the V4 tests across to V5 because they test a lot of edge cases. Thus, I'm backporting the testing system from V5 to V4 so that we can later copy the documents and results back to V5 and check for any regressions.

Performance impact

None, only affects tests.

Security impact

None, only affects tests.

Checklist

  • [x] My code matches the project's code style and yarn lint:fix passes.
  • [x] I've added tests for the new feature, and yarn test passes.
  • [x] I have detailed the new feature in the relevant documentation.
  • [x] I have added this feature to 'Pending' in the RELEASE_NOTES.md file (if one exists).
  • [x] If this is a breaking change I've explained why.

benjie avatar May 24 '22 12:05 benjie

CI is failing on PG9.4 because it does not support the workaround for too many function arguments. I think I previously had a flag that prevented that test running on old Postgres, will need to add that to the config... maybe something like requiresPg: 100000 (for 10.0.0)?

benjie avatar May 26 '22 15:05 benjie

requiresPg: 100000 (for 10.0.0)?

Works like a charm 👍🏻

jemgillam avatar May 27 '22 09:05 jemgillam