graphile-engine icon indicating copy to clipboard operation
graphile-engine copied to clipboard

Published 20 hours ago • verified publisher icon graphile

feat(graphile-utils): for makeChangeNullabilityPlugin, able to define array nullability, and Mutations and Queries args

Open GemN opened this issue 3 years ago • 1 comments

Description

In the makeChangeNullabilityPlugin Allow to use define nullability for Arrays. Allow manipulation of Queries and Mutation arguments

Performance impact

unknown

Security impact

unknown

Checklist

  • [x] My code matches the project's code style and yarn lint:fix passes.
  • [ ] I've added tests for the new feature, and yarn test passes.
  • [ ] I have detailed the new feature in the relevant documentation.
  • [ ] I have added this feature to 'Pending' in the RELEASE_NOTES.md file (if one exists).
  • [x] If this is a breaking change I've explained why.

GemN avatar Jul 21 '21 19:07 GemN

Thanks for the review, gonna do the changes this week when I have time!

GemN avatar Jul 27 '21 18:07 GemN

In V5 I went with a different solution whereby you specify strings like [[!]!]! to indicate the nullability. https://postgraphile.org/postgraphile/next/make-change-nullability-plugin

benjie avatar Aug 21 '23 12:08 benjie

To avoid breaking changes during the V4->V5 transition, this plugin would need to be refactored to use the new string-based solution to be merged into V4, and will need tests. Since it's been awaiting tests for a couple years, I'm going to close it; but I appreciate the work that went into it and it definitely inspired the V5 implementation - thanks! :pray:

benjie avatar Sep 27 '23 13:09 benjie