Rob Blafford
Rob Blafford
Updated the PR with a ducktape test that demonstrates the mechanism kicking in when enabled and not implementing backpressure when disabled
> > Importantly to note, this KIP doesn't attempt to constrain the number of global partition mutations, cluster wide. The KIP enforces the quota at the client level. > >...
~~Going to draft this as i'm realizing it will really depend on [KIP-482](https://cwiki.apache.org/confluence/display/KAFKA/KIP-482%3A+The+Kafka+Protocol+should+Support+Optional+Tagged+Fields) to implement correctly. This is due to the unfortunate fact that the version bumps required in the...
Rebased dev
> > Doing this enforcement on the leader was considered however it would be impossible to return the estimated calculated throttle response time without heavily modifying the API, which is...
@dotnwat in the [KIP-599](https://cwiki.apache.org/confluence/display/KAFKA/KIP-599%3A+Throttle+Create+Topic%2C+Create+Partition+and+Delete+Topic+Operations) documentation, its called `controller_mutations_rate*`, FWIW I'm up for changing it , i'm not married to the name I've chosen
In previous force push, I addressed concerns about lifetime of references on the stack within particular lambdas, and i moved the token bucket algorithm into the `kafka/` tree to not...
@ivotron it will be exercised indirectly because the ts-generator is consumed by src/js, which has tests that run in CI
CI error ``` du: cannot read directory ‘/var/lib/buildkite-agent/builds/buildkite-amd64-xfs-builders-i-056f02beb70b7cb77-1/redpanda/redpanda/vbuild/redpanda_installs/v22.1.4’: Permission denied | du: cannot read directory ‘/var/lib/buildkite-agent/builds/buildkite-amd64-xfs-builders-i-056f02beb70b7cb77-1/redpanda/redpanda/vbuild/redpanda_installs/v22.1.7’: Permission denied | du: cannot read directory ‘/var/lib/buildkite-agent/builds/buildkite-amd64-xfs-builders-i-056f02beb70b7cb77-1/redpanda/redpanda/vbuild/redpanda_installs/v22.1.3’: Permission denied | du: cannot read...
> @graphcareful doesn't look like that would be related to this change though? is something else broken here? not sure, i just clicked `rebuild` lets see if it works