graph4nlp icon indicating copy to clipboard operation
graph4nlp copied to clipboard

[Roadmap] Graph4NLP v0.6 plan

Open AlanSwift opened this issue 2 years ago • 17 comments

Task List

  • [New Feature] A brand new configuration system based on OmegaConf.
  • [Feature] Upgrade stanford CoreNLP to Stanza.
  • [Feature] Improve the dataset custermize experiments.
  • [Feature] Add relational GNN support.

AlanSwift avatar Feb 13 '22 16:02 AlanSwift

@AlanSwift looking forward to the relational GNN support.

By the way, without the support to run in a multiple-GPU environment, not sure how this library could be useful for large datasets. Do you plan to add support for multiple GPUs?

nashid avatar Feb 15 '22 01:02 nashid

@AlanSwift @hugochan @teddylfwu @SaizhuoWang this is a fantastic library. And to the best of my knowledge, this is the only GNN library that is NLP focused.

Would like to give some feedback about the library:

  • I think the effort for the library is misdirected. For example, the library has severe bug like Beam search is broken. I think any Major bug should be prioritized as that completely limits the use of the library.

  • Even if I look into the current Roadmap, I see effort is seriously misguided. The only major feature I see is adding relational GNN support which is great. But what's the point of so many bookkeeping tasks like add a brand new configuration system based on OmegaConf. These are just busy work that does not do much for an average user of the library. I am pretty sure a lot of effort would then be directed just to modify/update existing examples and to use this new configuration system.

Unfortunately that does not do much for a typical user. No one really cares that you are using OmegaConf configuration library. What matters is adding actual useful feature into the library. And it is extremely important to ensure the features that are already into the library actually works and there is no bug. Lets say you added R-GCN and it is buggy. Then the priority should be to fix that bug instead of updating a configuration system.

If there is a major bug, there is no point of adding more and more features into the library. To summarize, for any software engineering tasks, there needs to be a balance between what is "actual feature" vs "doing chores" (like updating configuration system) which does not add much to the library.

This is just my 2 cents. And again - thanks for this fantastic library.

ramsey-coding avatar Mar 09 '22 19:03 ramsey-coding

@AlanSwift @hugochan @teddylfwu @SaizhuoWang Furthermore, I see in the description work on configuration system is stated as a New Feature:

[New Feature] A brand new configuration system based on OmegaConf

This is not a feature. Feature is something that adds value to a project. So the understanding of what is called as a "feature" is wrong. It should be stated "Code Debt" or "Maintenance" work.

ramsey-coding avatar Mar 09 '22 23:03 ramsey-coding

@AlanSwift wondering when the RGCN implementation would be available?

nashid avatar Jun 16 '22 22:06 nashid

When the new release would be announced?

smith-co avatar Jun 24 '22 03:06 smith-co

@AlanSwift @hugochan @teddylfwu @SaizhuoWang @xiao03 wondering when this library version would be released 🙏 🙏 🙏 ?

code-rex1 avatar Aug 05 '22 07:08 code-rex1

Reply to all: We will have a meeting this weekend. I think the new release will come in two weeks. Really sorry for the delay.

AlanSwift avatar Aug 05 '22 07:08 AlanSwift

@AlanSwift this is a great library for GNN. Looking forward to the release specially the implementation of RGCN.

Also if you could support transformer in the future, would a great feature for this useful library.

code-rex1 avatar Aug 05 '22 20:08 code-rex1

Yes. The full support of the transformer is on schedule. The transformer encoder will release in the next coming version. And the transformer decoder will come soon (on test). @code-rex1

AlanSwift avatar Aug 06 '22 02:08 AlanSwift

@AlanSwift looking forward to use the transformer encoder 🥇. When would it be release?

smith-co avatar Sep 03 '22 21:09 smith-co

Wondering what's the tentative timeline for this release.

smith-co avatar Sep 15 '22 03:09 smith-co

We are still discussing it #578. We still need 2-3 weeks to make it ready since it covers many features. @smith-co

AlanSwift avatar Sep 18 '22 18:09 AlanSwift

@AlanSwift wondering when the RGCN implementation would be available?

nashid avatar Nov 04 '22 01:11 nashid

@AlanSwift wondering when the RGCN implementation would be available?

We have almost finished the implementation and currently are testing on down tasks. We are sorry we delayed too much time since it is a big feature migration from the homogeneous graph to the heterogeneous graph.

AlanSwift avatar Nov 19 '22 12:11 AlanSwift

Really looking forward to it. Thanks @AlanSwift

nashid avatar Nov 19 '22 22:11 nashid

@AlanSwift Could you please tell me when would new version be released?

dmbs335 avatar Jan 09 '23 05:01 dmbs335

Wondering is there a further update?

nashid avatar Apr 22 '23 22:04 nashid