graphql-go icon indicating copy to clipboard operation
graphql-go copied to clipboard

defer/stream support

Open agnivade opened this issue 3 years ago • 2 comments

I am creating this issue to start a discussion on implementing @defer/@stream support. Doing a search for existing issues, I could only find https://github.com/graph-gophers/graphql-go/issues/15 but that's only about subscriptions.

I have a use-case where my clients require @stream support to stream large payloads. I can go ahead and take a stab at implementing this, but I wanted to check if there has been any prior discussion around this and if anybody has any thoughts/comments on what things to consider?

Attaching the spec here: https://github.com/graphql/graphql-wg/blob/main/rfcs/DeferStream.md

cc @tonyghita @pavelnikolov

agnivade avatar Dec 08 '21 14:12 agnivade

@agnivade I am not aware of anyone working on this. Considering that it's still a draft maybe we need to mention in the release later that this feature will be experimental. As long as it's opt-in and it doesn't introduce any breaking changes - go for it.

pavelnikolov avatar Dec 08 '21 15:12 pavelnikolov

Yep, it's a directive on the client side, so totally opt-in. Thanks, I'll make an attempt soon.

agnivade avatar Dec 09 '21 03:12 agnivade

@agnivade I'm closing this issue due to inactivity. Feel free to open it if you decide to work on this or in case this feature gets accepted to the official spec.

pavelnikolov avatar Mar 07 '23 13:03 pavelnikolov

Sounds good. And my apologies for the delay. There has been some changes in company roadmap unfortunately which is not allowing me to invest more time in this.

agnivade avatar Mar 07 '23 13:03 agnivade