Refactored and Updated

[pwnyprod]

• Updated the Extension for usage with codeception 4.x and php7.4
• refactored Codebase
• added tests
• added github testing action for better Contributions

TODO:

• test in real environment

[grantlucas]

Thanks for the PR. I'll need to give it a review in the next few days.

[grantlucas]

@pwnyprod Thanks again for the PR, I've setup a small repo for testing the 2.x version of Phantoman, and to better test incoming PRs like yours.

I've set up a branch there and have confirmed that your overall work loads PhantomJS well!

Once some other things are addressed in this PR, things look like they'll be good to go and a great update for this project.

[pwnyprod]

@grantlucas your phan addition in the workflows make problems now. I changed the things you mentioned in the PR. Is this good for now so we can merge?

[grantlucas]

@pwnyprod Looking at the Code Quality checks, the static analysis is failing for the following reasons

src/Configurator/Configurator.php:85 PhanTypeMismatchArgumentInternal Argument 2 ($values) is $config['debug'] of type false but \sprintf() takes float|int|string

That failure is possibly why the tests are failing but not totally sure. Ironing out the static analysis would at least narrow it down.

Additionally it's identified an unused use statement that can be removed. Looking at that file, it indeed looks like CommandHandlerInterface isn't used anywhere in the file.

src/PhantomJsServer/PhantomJsServer.php:6 PhanUnreferencedUseNormal Possibly zero references to use statement for classlike/namespace CommandHandlerInterface (\Codeception\Extension\CommandHandler\CommandHandlerInterface)