python-wordsegment icon indicating copy to clipboard operation
python-wordsegment copied to clipboard

Moved the metadata out of `setup.py` into `setup.cfg`.

Open KOLANICH opened this issue 4 years ago • 2 comments

Added pyproject.toml. Replaced importing the version variable with reading it from the file using read_version. If we drop python3 ./setup.py test, then setup.py can be removed completely since now (to build one should use python3 -m build -nwx).

KOLANICH avatar Sep 13 '21 15:09 KOLANICH

Does the current setup.py cause you problems?

grantjenks avatar Sep 13 '21 16:09 grantjenks

setup.py is a security issue. It is code execution at the time of building a wheel from source. Since tools in python ecosystem support the declarative config (setup.cfg is supported in setuptools since 2016, setuptools support projects without setup.py since 2019, pip supports projects without setup.py since my PR fixing that has landed 2021-03-04)

KOLANICH avatar Sep 13 '21 16:09 KOLANICH