node-rethinkdb-job-queue icon indicating copy to clipboard operation
node-rethinkdb-job-queue copied to clipboard

impl: added change-feed reConnection mechanism

Open KrishnaPG opened this issue 3 years ago • 2 comments

Enables change-feed reconnection when the connection drops.

  • New reconnect options have been added that expose the pingInterval as well as connection reattempt controls

Note that this reconnection is only limited to the change feeds and other parts of the package, such as dbAssertion etc. still may fail on connection failure.

KrishnaPG avatar Nov 18 '20 09:11 KrishnaPG

Hi @KrishnaPG. Sorry for the late reply. This went under my radar for some reason.

I can't see any unit tests added for this change. It looks great otherwise.

Can you add a unit test or two?

grantcarthew avatar Mar 18 '21 04:03 grantcarthew

On a side note @KrishnaPG, are you interested in becoming a maintainer? Are you a JavaScript ninja? Your profile indicates some level of skill.

grantcarthew avatar Mar 18 '21 04:03 grantcarthew