Grant Timmerman

Results 140 comments of Grant Timmerman

> Yes, that + `onunhandledrejection` would be perfect. I'm not sure what you mean by this. With the above suggestion, you can catch all Node exceptions in a function handler....

@ajjindal Is there anything else regarding grabbing uncaught exceptions that we can do? https://github.com/GoogleCloudPlatform/functions-framework-nodejs/issues/215#issuecomment-693024635 provides some code samples and links to docs. If not, can I close this issue?

I believe multiple event handlers are possible. It might require the function to be deployed on Node.js 12+. Did you try `beforeExit`, `exit`, or other Node lifecycle events?

I'm going to loop back with the Functions team about this. Would a delay of 5 seconds or so before sending the HTTP response on `unhandledException` fix the issue? Then...

Re: https://github.com/GoogleCloudPlatform/functions-framework-nodejs/issues/215#issuecomment-702438337 @ajjindal @marshall-lee Can you let us know what change you're looking for, or if this solution would work?

Pardon the delay. Having 1+ user defined async global error handlers would be fine, but I don't think there's a concrete proposed design. Can you describe a bit more how...

> For now I only tested my drafted approach starting `functions-framework` as a binary locally on my computer. Everything worked fine. Why do you think it doesn't work with binary?...

The thing with starting the framework with... ```js const framework = require("@google-cloud/functions-framework"); ``` ...is that currently the Functions Framework registers error handlers immediately, so you cannot add custom handlers. That's...

How did we want the interface to be for the optional type annotation for CloudEvent data types? Would this work for both declarative and non-declarative functions? I could imagine a...

I prototyped a version of type annotation in this branch: https://github.com/GoogleCloudPlatform/functions-framework-nodejs/compare/grant_declarative_types?expand=1