Pl3xMap icon indicating copy to clipboard operation
Pl3xMap copied to clipboard

removed unused dependency

Open SebiTimeWaster opened this issue 2 months ago • 3 comments

removed unused "recommends" dependency to "better-fabric-console" that is not used in code and creates warnings in the game console if not installed.

SebiTimeWaster avatar Oct 25 '25 00:10 SebiTimeWaster

I agree with the warning that it shows.

[14:09:17] [main/WARN]: Warnings were found! - Mod 'Pl3xMap' (pl3xmap) 1.21.10-SNAPSHOT recommends any version of better-fabric-console, which is missing! - You should install any version of better-fabric-console for the optimal experience.

I'm not interested in removing it since it significantly improves the server owner's experience and makes using pl3xmap that much easier in the console.

What does changing the keyword to "suggests" do? Does it give the same warning?

granny avatar Oct 25 '25 02:10 granny

fabric documentation says:

recommends: For dependencies not required to run. For each missing dependency, Fabric Loader will log a warning.
suggests: For dependencies not required to run. Use this as a kind of metadata.

i interpret this as "you use it in your code if it is installed, but you can run without it". (since a dependency is always something that is to be installed so it can be used by your code)

if you deem "better-fabric-console" essential for using Pl3xmap, then why is there no mention of it in the readme on Github or Modrinth? thats the place where you should mention things that are not dependencies but can make the experience better.

also id like to point out that not everyone interacts with Pl3xmap in the console, i didnt even know thats a possibility, we just use it to show a map, nothing more. also we use a hoster for game servers, which means we have no direct access to the console and i doubt the mod would help us in any way, since we access the console over a web interface that doesnt send control characters for tab, arrow up, etc.

SebiTimeWaster avatar Oct 25 '25 15:10 SebiTimeWaster

also id like to point out that not everyone interacts with Pl3xmap in the console, i didnt even know thats a possibility, we just use it to show a map, nothing more.

This is precisely why it is the way it is. Its for server admins that use the console to see. Using suggests instead of recommends will fail to print anything to the console. The entire purpose is to be plainly seen by the server admin using the console.

BillyGalbreath avatar Oct 26 '25 08:10 BillyGalbreath