python-goose icon indicating copy to clipboard operation
python-goose copied to clipboard

Switching to beautifulsoup4 for Python 3 support?

Open frnsys opened this issue 11 years ago • 4 comments

Are there any plans to change the beautifulsoup dependency to beautifulsoup4 for Python 3 support? Or are there other factors as well before this will be py3 compatible?

frnsys avatar Jan 05 '14 21:01 frnsys

Please ignore the first of these commits – that one wasn't properly synced with the develop branch.

The latter commit is starting work on a port to Python 3. All tests pass except for tests.extractors.TestExtractChinese because the jieba package is not Py3 compatible.

I tried to preserve Py2.7 compatibility where I could, but I don't have much experiencing porting to Python 3 so the changes need review from someone more experienced.

frnsys avatar Feb 02 '14 22:02 frnsys

@ftzeng I'm really interested in your py3 port once it will be functional

xav

grangier avatar Feb 07 '14 05:02 grangier

I think the two biggest issues with my port so far are:

  • Python 2.7 compatible string unicode/byte handling
  • The BeautifulSoup parser...I believe my workaround sidesteps it entirely in the Python 3 port which is likely not the desired behavior

frnsys avatar Feb 07 '14 17:02 frnsys

suppose in case of porting this would be useless https://github.com/grangier/python-goose/issues/136

vladimir-shmidt avatar Aug 11 '14 10:08 vladimir-shmidt